fix memory corruption bug of cron module #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a bug of vixie cron, which bit_nset and bit_nclear are used to set and clean bits of range [start, stop], for `dow` and `hour`, they use 8 bits and 24bits, the following statement will write the next byte since the pass the length instead of the stop position, which will corrupt the memory. bit_nset(e->hour, 0, (LAST_HOUR-FIRST_HOUR+1)); bit_nset(e->dow, 0, (LAST_DOW-FIRST_DOW+1)); bit_nclear(bits, 0, (high-low+1)); Paul vixie(the author of vixie cron) fix this with some code refactory, this patch just backport it back to pg_cron. The original PRs: 1. vixie/cron#16 2. vixie/cron#18 Signed-off-by: Junwang Zhao <zhjwpku@gmail.com>
|
@marcocitus can you take some time to review this PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug of vixie cron, which bit_nset and bit_nclear are used to set and clean bits of range [start, stop], for
dowandhour, they use 8 bits and 24bits, the following statement will write the next byte since the pass the length instead of the stop position, which will corrupt the memory.bit_nset(e->hour, 0, (LAST_HOUR-FIRST_HOUR+1));
bit_nset(e->dow, 0, (LAST_DOW-FIRST_DOW+1));
bit_nclear(bits, 0, (high-low+1));
Paul vixie(the author of vixie cron) fix this with some code refactory, this patch just backport it back to pg_cron.
The original PRs: