Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable :missing-docstring linter for test code #288

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

athos
Copy link
Member

@athos athos commented Nov 8, 2023

PR #282 has turned on the :missing-docstring linter, but it's not so much beneficial to enable it for the test code (Especially, cljam.test-common has lots of definitions without docstring, which is overwhelming the linter on my editor 🥹).

This PR narrows down the scope of the :missing-docstring linter to the product code.

@athos athos self-assigned this Nov 8, 2023
@athos athos requested review from alumi and a team as code owners November 8, 2023 00:57
@athos athos requested review from r6eve and removed request for a team November 8, 2023 00:57
@athos athos assigned alumi and r6eve Nov 8, 2023
Copy link
Contributor

@r6eve r6eve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@r6eve r6eve merged commit 14e0deb into master Nov 8, 2023
18 checks passed
@r6eve r6eve deleted the feature/disable-missing-docsting-for-test branch November 8, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants