Extend the supported data types in encoding alignment options #265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 88.87% 88.80% -0.07%
==========================================
Files 78 78
Lines 6389 6406 +17
Branches 442 453 +11
==========================================
+ Hits 5678 5689 +11
+ Misses 269 264 -5
- Partials 442 453 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Thank you for another PR @matsutomo81 👍 I added a comment about your concerns.
Since I just merged #264, please rebase and force-push to this branch when you finish editing the tests 🙏
matsutomo81
force-pushed
the
feature/Extend_the_supported_data_types_in_encoding_aln_options
branch
from
8b5ca1e
to
c47ebe3
Compare
There was a problem hiding this comment.
When you are done editing a PR, please click the "Re-request review" button on the reviewers list 🙏
matsutomo81
force-pushed
the
feature/Extend_the_supported_data_types_in_encoding_aln_options
branch
from
c47ebe3
to
33e5f1b
Compare
There was a problem hiding this comment.
Thank you for updating the patch. Looks good 👍
It is recommended not to force-push to the PR branch while being reviewed on GitHub. This is meant for keeping track of inline review comments across commits. You can clean your commits up when all reviewers approve your PR if necessary.
The topic of this PR is about encoding SAM format into BAM format. According to BAM format specification, there are several data types for options in the alignment, but current cljam doesn't support all of them for encoding. If you try to encode a data type that is not supported, an Execution error will be returned.
This PR extends the data types of options that can be encoded, so that all data types except the H-type can be supported. Since the H-type seems to be a specification that remains only for backward compatibility, this PR did not provide support for the H-type encoding. Tests have also been added for the functions I have modified.