-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix float reader for specific environments such as IcedTea. #185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 76 76
Lines 6011 6011
Branches 499 499
=======================================
Hits 5208 5208
Misses 304 304
Partials 499 499
Continue to review full report at Codecov.
|
Sorry,I missed warning.I'll fix it. |
866f5a6
to
56da0fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks!! |
Thank you for reviewing. |
In some environments such as "IcedTea",Float reader in Bcf reader doesn't work as expected.
Specifically, the result of reading NaN is expected to be 0x800001, but the result will be different.
The fix is to read as int and convert to float if not NaN.