Avoid an ArityException on creating an index for BAM files without alignments #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
r6eve and
yito88
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 86.92% 86.92%
=======================================
Files 74 74
Lines 5765 5765
Branches 490 490
=======================================
Hits 5011 5011
Misses 264 264
Partials 490 490
Continue to review full report at Codecov.
|
r6eve
approved these changes
Sep 26, 2019
alumi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cljam.algo.bam-indexer/create-indexthrows anclojure.lang.ArityExceptionwhen the target BAM contains no alignmentsCause
An initial value is not provided for
(reduce merge-index [])incljam.io.bam-index.writer/make-index-from-blockscljam/src/cljam/io/bam_index/writer.clj
Line 310 in 2db7fe7
Changes
Add a default value for
make-index-from-blocksAffects
cljam.algo.bam-indexercljam.io.bam-index.writerTests
lein check✅lein test :all✅