Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D and 3D Noh tests don't run on dev #323

Closed
evazlimen opened this issue Aug 25, 2023 · 0 comments · Fixed by #331
Closed

2D and 3D Noh tests don't run on dev #323

evazlimen opened this issue Aug 25, 2023 · 0 comments · Fixed by #331

Comments

@evazlimen
Copy link
Collaborator

When running the 2 and 3D example noh problems on dev, you get "ABORT: noh -> Unknown custom boundary condition."

This looks like it is coming from cholla/src/grid/boundary_conditions.cpp:

void Grid3D::Custom_Boundary(char bcnd[MAXLEN])     
{  
  if (strcmp(bcnd, "noh") == 0) {  
    // from grid/cuda_boundaries.cu  
    Noh_Boundary();  
  }  
  if (strcmp(bcnd, "wind") == 0) {  
    // from grid/cuda_boundaries.cu  
    Wind_Boundary();  
  } else {  
    printf("ABORT: %s -> Unknown custom boundary condition.\n", bcnd);  
    exit(0);  
  }  
} 

strcmp(bcnd, "noh") is returning 0, but it is still checking if strcmp(bcnd, "wind")==0
If you change the second if statement to an else if statement the tests run. They run on main as there is only the one if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant