Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patched Surelog in favor of upstream patch. #2755

Closed
QuantamHD opened this issue Mar 14, 2022 · 3 comments
Closed

Remove patched Surelog in favor of upstream patch. #2755

QuantamHD opened this issue Mar 14, 2022 · 3 comments

Comments

@QuantamHD
Copy link
Collaborator

QuantamHD commented Mar 14, 2022 •
edited
Loading

I worked with the upstream ANTLR team to integrate a faster RTTI implementation into ANTLR. When this PR antlr/antlr4#3584 is merged in, the forked version of ANTLR in Surelog will have no definable benefits over upstream.

If this patch is merged we should move to upstream ANTLR.
@QuantamHD
Copy link
Collaborator Author

It's merged in the dev branch upstream. Shall we update the submodule?

@alaindargelas
Copy link
Collaborator

Experiments still show Surelog version is 40% faster than the Antlr 4.10 dev branch.
Waiting for further improvements in Antlr 4.10

@alaindargelas
Copy link
Collaborator

Will be addressed by #2845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuantamHD @alaindargelas