Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(response-interceptor.md): improve example #891

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

bangank36
Copy link
Contributor

@bangank36 bangank36 commented Mar 4, 2023

Description

  • Update Text replacement example for Response Interceptor

Motivation and Context

  • In the Replace text and change http status code example, changing Hello to Teapot won't show anything since there is no Hello string in http://www.example.com
  • Suggest to update string Example, also should use replaceAll since the Example is in the document title as well, so it maybe hard to notice the change

How has this been tested?

  • Run an express app with target http://www.example.com
  • Make sure the word Example is changed Hello

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

- Update text replacement example
@coveralls
Copy link

Coverage Status

Coverage: 97.872%. Remained the same when pulling 767917b on bangank36:patch-1 into 47b7e01 on chimurai:master.

@chimurai chimurai changed the title Update response-interceptor.md docs(response-interceptor.md): improve example Mar 4, 2023
@chimurai chimurai merged commit ba740e9 into chimurai:master Mar 4, 2023
@chimurai
Copy link
Owner

chimurai commented Mar 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants