From 7f3565bdf4644ab5caeb1fa79a69d67c9cd9f3a2 Mon Sep 17 00:00:00 2001 From: Kyle Farnung Date: Tue, 11 Jul 2017 08:17:14 -0700 Subject: [PATCH] PR feedback --- lib/Jsrt/Jsrt.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Jsrt/Jsrt.cpp b/lib/Jsrt/Jsrt.cpp index 4b504b55c20..6a424aaf3d1 100644 --- a/lib/Jsrt/Jsrt.cpp +++ b/lib/Jsrt/Jsrt.cpp @@ -1347,7 +1347,7 @@ CHAKRA_API JsGetExtensionAllowed(_In_ JsValueRef object, _Out_ bool *value) VALIDATE_INCOMING_OBJECT(object, scriptContext); PARAM_NOT_NULL(value); - *value = nullptr; + *value = false; *value = Js::RecyclableObject::FromVar(object)->IsExtensible() != 0; @@ -1473,7 +1473,7 @@ CHAKRA_API JsHasProperty(_In_ JsValueRef object, _In_ JsPropertyIdRef propertyId VALIDATE_INCOMING_OBJECT(object, scriptContext); VALIDATE_INCOMING_PROPERTYID(propertyId); PARAM_NOT_NULL(hasProperty); - *hasProperty = nullptr; + *hasProperty = false; *hasProperty = Js::JavascriptOperators::OP_HasProperty(object, ((Js::PropertyRecord *)propertyId)->GetPropertyId(), scriptContext) != 0; @@ -1510,7 +1510,7 @@ CHAKRA_API JsDefineProperty(_In_ JsValueRef object, _In_ JsPropertyIdRef propert VALIDATE_INCOMING_PROPERTYID(propertyId); VALIDATE_INCOMING_OBJECT(propertyDescriptor, scriptContext); PARAM_NOT_NULL(result); - *result = nullptr; + *result = false; Js::PropertyDescriptor propertyDescriptorValue; if (!Js::JavascriptOperators::ToPropertyDescriptor(propertyDescriptor, &propertyDescriptorValue, scriptContext)) @@ -4740,7 +4740,7 @@ CHAKRA_API JsHasOwnProperty(_In_ JsValueRef object, _In_ JsPropertyIdRef propert VALIDATE_INCOMING_OBJECT(object, scriptContext); VALIDATE_INCOMING_PROPERTYID(propertyId); PARAM_NOT_NULL(hasOwnProperty); - *hasOwnProperty = nullptr; + *hasOwnProperty = false; *hasOwnProperty = Js::JavascriptOperators::OP_HasOwnProperty(object, ((Js::PropertyRecord *)propertyId)->GetPropertyId(), scriptContext) != 0;