Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to a safe hash function when computing hashes locally #397

Closed
I-Al-Istannen opened this issue Aug 30, 2023 · 2 comments · Fixed by #398
Closed

Default to a safe hash function when computing hashes locally #397

I-Al-Istannen opened this issue Aug 30, 2023 · 2 comments · Fixed by #398

Comments

@I-Al-Istannen
Copy link
Contributor

SHA-1 is deprecated and attacks seem to be becoming more and more feasible. As maven uses SHA-1 hashes for remotes, we are also stuck with this decision when re-using them. However, if we compute hashes ourselves (as we probably should), we can default to a better hash function.

@MartinWitt
Copy link
Contributor

SHA256 should be fine, or do you believe we should already adopt a more robust hash for local hashes?

@I-Al-Istannen
Copy link
Contributor Author

SHA256 is probably fine and it is widely supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants