Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renders multiple instances of Hint on Hotgrid components #137

Closed
simondate opened this issue Jun 7, 2022 · 5 comments · Fixed by #138
Closed

Renders multiple instances of Hint on Hotgrid components #137

simondate opened this issue Jun 7, 2022 · 5 comments · Fixed by #138
Assignees

Comments

@simondate
Copy link
Contributor

Due to the Hotgraphic component having both a desktop Hotgraphic and Narrative mobile view, the Hint renders twice

@kirsty-hames
Copy link
Contributor

Hey @simondate, I can't replicate this issue testing with latest FW v5.31.12 and Hint v3.0.0.
Could you please confirm your environment if the issue still exists?

@simondate
Copy link
Contributor Author

I just tried to replicate on an old course (which may or may not have been the one I reported on), and couldn't replicate.

I'll just close this issue.

@kirsty-hames
Copy link
Contributor

I'm reopening this issue but I'm finding it specific to the Hotgrid component when resizing the browser. All core components work as expected.

The resizing of the browser causes another instance of Hint to render. See screenshot.

hint_rendering_multiple_instances

I've sporadicly tested this with different FW and Hotgrid versions and can replicate each time.
FW v5.31.7 / 5.31.11 / 5.31.12,
Hotgrid v4.3.13 / 4.4.0,
Hint v3.0.0

@kirsty-hames kirsty-hames reopened this Jul 5, 2023
@kirsty-hames kirsty-hames changed the title Renders twice on Hotgraphics Renders multiple instances on Hotgrid components Jul 5, 2023
@joe-allen-89 joe-allen-89 self-assigned this Nov 7, 2023
@joe-allen-89
Copy link
Contributor

Tested with multiple components and can only replicate with hotgrid, linked to calling this.render() on device change. Transferring issue to hotgrid.

@joe-allen-89 joe-allen-89 transferred this issue from cgkineo/adapt-hint Nov 7, 2023
@kirsty-hames kirsty-hames changed the title Renders multiple instances on Hotgrid components Renders multiple instances of Hint on Hotgrid components Nov 7, 2023
@joe-allen-89 joe-allen-89 linked a pull request Nov 7, 2023 that will close this issue
Copy link

🎉 This issue has been resolved in version 4.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants