Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bambenek parser broken? (pull request added) #1525

Closed
pettai opened this issue May 7, 2020 · 4 comments
Closed

Bambenek parser broken? (pull request added) #1525

pettai opened this issue May 7, 2020 · 4 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@pettai
Copy link
Contributor

pettai commented May 7, 2020 •
edited
Loading

Some of the Bambenek feeds have moved location and it seems like the parser doesn't handle the feed anymore.

UPDATE: the parser was dependent on correct feed.url, and new URLs has been added for licensed downloads, #1526 fixes this

There was some documentation on all possible feeds / data sources here somewhere, that should probably be updated about the Bambenek feed license too
@pettai pettai closed this as completed May 7, 2020
@pettai
Copy link
Contributor Author

pettai commented May 7, 2020

wrong file was being parsed, but there is room for future improvements of the parser...

@pettai pettai reopened this May 8, 2020
@pettai
Copy link
Contributor Author

pettai commented May 8, 2020

This fixes the problem #1526

@pettai pettai changed the title Bambenek parser broken? Bambenek parser broken? (pull request added) May 8, 2020
@ghost
Copy link

ghost commented May 13, 2020

Thanks!

So the feed is now private and no more public?

@ghost ghost added the bug Indicates an unexpected problem or unintended behavior label May 13, 2020
@pettai
Copy link
Contributor Author

pettai commented May 15, 2020

Some require a license now, but the DGA feed seems to be left for public use

@ghost ghost closed this as completed in ce1d00c May 18, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pettai