Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate various missed code-paths to SDK v3 #1464

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 16, 2024

Changes to production code

  • Migrated inventory canary function to SDK v3.
  • Migrated package versions table widget function to SDK v3.
  • Pulled out a new shared helper function to decompresses a possibly gzip'ed blob stream into a string. It's used in the above migrations.
  • Updated imports in some lambda handlers from import * as aws to explicitly importing the used clients to make it more obvious which code has already been migrated.
  • Removed some now unused SDK v2 clients from the shared client code.
  • Fixed an issue in the shared s3ObjectExists helper that would only return false when the bucket is not found, but not when the key is not found.

Changes to test cases

  • Cleanup of old mocks in some unit tests.
  • Refactor deny-list integ test to use assertions instead of triggers. As it was, this integ test still blocked automated dependencies updates because the hash of the trigger functions would change, causing a replacement of the trigger function. This was classified as a destructive change and failed the test. With assertions, these kind of changes are excluded.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain marked this pull request as ready for review September 16, 2024 11:09
@mrgrain mrgrain force-pushed the mrgrain/fix/migrate-to-sdk-v3 branch from ecb4b0d to a73c730 Compare September 16, 2024 11:09
@mrgrain mrgrain force-pushed the mrgrain/fix/migrate-to-sdk-v3 branch from a73c730 to 045e4a6 Compare September 16, 2024 11:13
@cdklabs-automation cdklabs-automation added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 3052baf Sep 16, 2024
6 checks passed
@cdklabs-automation cdklabs-automation deleted the mrgrain/fix/migrate-to-sdk-v3 branch September 16, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants