Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cleanup-on-shutdown; update to 0.2.0 #5

Merged
merged 1 commit into from
May 11, 2024
Merged

added cleanup-on-shutdown; update to 0.2.0 #5

merged 1 commit into from
May 11, 2024

Conversation

gewang
Copy link
Member

@gewang gewang commented May 10, 2024

propagating the changes for FaucK within chuck-max back...

for compatibility, I added this preprocessor check to Faust.cpp, which should compile with both chugin-10.1 and chugin-10.2 API version (the latter will clean up and addresses a potential crash-on-exit):

#if( CK_DLL_VERSION_MAJOR >= 10 && CK_DLL_VERSION_MINOR >= 2 )
    // register a callback to be called upon host shutdown (so we can clean up)
    QUERY->register_callback_on_shutdown(QUERY, cb_on_host_shutdown, NULL);
#endif

for now, did not change chugin.h (it's still 10.1). Everything should be bumped up to chugin API 10.2 by the next chuck release (1.5.2.5).

@gewang gewang requested a review from DBraun May 10, 2024 21:29
Faust.cpp Show resolved Hide resolved
@gewang
Copy link
Member Author

gewang commented May 11, 2024

btw, this will address the weird mutex crash-on-exit issue; however, the fix won't take effect until we update chugin.h from 10.1 (current) to 10.2 (upcoming). But the code to take advantage of it in Faust.cpp is part of this PR.

@DBraun DBraun merged commit de7af15 into main May 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants