Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README on npmjs.org is incorrect and inconsistent with README here in master #66

Open
newhouse opened this issue Sep 7, 2017 · 0 comments

Comments

@newhouse
Copy link

newhouse commented Sep 7, 2017

The README for this package on npmjs.org is not the same as the README here in the repo. The versions are the same, however, it looks like when the examples and README were updated here, they were not pushed to NPM. Specifically, the NPM docs are still showing primus.use('rooms', Rooms); when they should be showing primus.plugin('rooms', Rooms);.

This really cost me a lot of time by following the example off of the NPM website and finding it not working. I almost bailed on Primus and it definitely made me nervous about it.

I'd suggest a patch or whatever to get the changes to take affect in NPM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant