Add boolean and Timestamp to min max #4245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4174
The error is caused as Boolean is not a specified return type in the dialect functions.
The
min
andmax
functions currently only return Numeric and Character types.Extend this for Boolean and Timestamps as well
Sqlite and MySql don't have a native boolean type
Postgres has a boolean type and doesn't allow '1' or '0' to be treated as boolean
Note: As
min
andmax
are nullable return types, will be a custom result rather than a primitiveTodo - mysql
consider #4211
#4243