Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If every type of an expression is the same return that type as a result #4211

Closed
wants to merge 1 commit into from
Closed

If every type of an expression is the same return that type as a result #4211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sqldelight-compiler/dialect/src/main/kotlin/app/cash/sqldelight/dialect/api/TypeResolver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ fun TypeResolver.encapsulatingType(
nullableIfAny: Boolean,
vararg typeOrder: DialectType,
): IntermediateType {
val types = exprList.map { resolvedType(it) }
val types = exprList.map { resolvedType(it) }.distinct()
if (types.size == 1) return types[0]

val sqlTypes = types.map { it.dialectType }

if (PrimitiveType.ARGUMENT in sqlTypes) {
Expand Down
3 changes: 3 additions & 0 deletions ...test/integration-mysql/src/main/sqldelight/app/cash/sqldelight/mysql/integration/Dates.sq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ INSERT INTO dates VALUES (?, ?, ?, ?, ?);

SELECT * FROM dates LIMIT 1;
}

selectMaxTimestamp:
SELECT max(timestamp) FROM dates LIMIT 1;