Support updating a view which has a INSTEAD OF trigger #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Apr 11, 2022
JakeWharton
approved these changes
Apr 11, 2022
| @@ -35,8 +35,8 @@ sealed class NamedMutator( | |||
| ) : NamedExecute(identifier, statement) { | |||
| val containingFile = statement.sqFile() as SqlDelightQueriesFile | |||
|
|
|||
| internal val tableEffected: TableNameElement by lazy { | |||
| tableName.referencedTables().single() | |||
| internal val tableEffected: Collection<TableNameElement> by lazy { | |||
There was a problem hiding this comment.
nit: table -> tables, effected -> affected
AlecKazakova
force-pushed
the
astrong/2022-04-11/support-updating-views-with-triggers
branch
from
1cf8af2
to
8b0c346
Compare
AlecKazakova
deleted the
astrong/2022-04-11/support-updating-views-with-triggers
branch
AlecKazakova
pushed a commit
that referenced
this pull request
Apr 11, 2022
AlecKazakova
pushed a commit
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1018