If every type of an expression is the same return that type as a result

cashapp · May 30, 2023 · d6f7c08 · d6f7c08
1 parent c22e6df
commit d6f7c08
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/sqldelight-compiler/dialect/src/main/kotlin/app/cash/sqldelight/dialect/api/TypeResolver.kt b/sqldelight-compiler/dialect/src/main/kotlin/app/cash/sqldelight/dialect/api/TypeResolver.kt
@@ -54,7 +54,9 @@ fun TypeResolver.encapsulatingType(
   nullableIfAny: Boolean,
   vararg typeOrder: DialectType,
 ): IntermediateType {
-  val types = exprList.map { resolvedType(it) }
+  val types = exprList.map { resolvedType(it) }.distinct()
+  if (types.size == 1) return types[0]
+
   val sqlTypes = types.map { it.dialectType }
 
   if (PrimitiveType.ARGUMENT in sqlTypes) {

diff --git a/...test/integration-mysql/src/main/sqldelight/app/cash/sqldelight/mysql/integration/Dates.sq b/...test/integration-mysql/src/main/sqldelight/app/cash/sqldelight/mysql/integration/Dates.sq
@@ -11,3 +11,6 @@ INSERT INTO dates VALUES (?, ?, ?, ?, ?);
 
 SELECT * FROM dates LIMIT 1;
 }
+
+selectMaxTimestamp:
+SELECT max(timestamp) FROM dates LIMIT 1;