Exclude invalid filename characters from snapshot files

[lynnkale]

Windows does not allow the following characters in filenames: < > : " / \ | ? * but if these values are included in test parameters, they are included in the file names as well. This causes problems if tests are created with invalid characters on a *nix system but someone tries to run them on a windows machine.

[geoff-powell]

I was able to repo this with a new test. https://github.com/cashapp/paparazzi/actions/runs/10356499878/job/28666472264?pr=1534

[jrodbx]

@lynnkale do you have a example handy which highlights "but if these values are included in test parameters"?

Looking at TestParameterInjectorTest, I suppose using a TestParameterValuesProvider that supplies a list of Strings whose literals contain those invalid characters would be one way. Still, I'd be curious to see your specific use case to ensure things are now fixed.

[lynnkale]

@jrodbx Most of the tests I was having issues with were using TestParameterValuesProvider supplying strings with invalid characters, for example "Title | Subtitle". The other case was a state class with an Exception attribute. It was using ErrorState(exception = Exception("error string")) which was producing a file name with a colon.

I can't provide direct code examples here, unfortunately, but I'm hoping this provides enough information to verify.

Thank you!