Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Just builds and passes tests with minimal versions of dependencies #459

Closed
casey opened this issue Jul 8, 2019 · 0 comments · Fixed by #487
Closed

Ensure Just builds and passes tests with minimal versions of dependencies #459

casey opened this issue Jul 8, 2019 · 0 comments · Fixed by #487

Comments

@casey
Copy link
Owner

casey commented Jul 8, 2019

Debian requires that dependent crates be packaged independently. Since the Debian-packaged versions of crates might lag behind the latest version on crates.io, packagers benefit from being able to package older versions of dependencies, since that older version may already be packaged for Debian.

So, in order to give packagers the most flexibility possible when packaging Just, we should make sure that Just actually builds and passes tests with the minimal versions of dependencies, as declared in Cargo.lock.

To ensure this, I'd like to formalize the process of adding and updating dependencies. So far I've done this on an ad-hoc basis, but I think I should actually write a Just recipe that encompasses those steps.

One check that those steps should include is running cargo +nightly generate-lockfile -Z minimal-versions && cargo test, to ensure that just builds and passes all tests with the minimal version of dependencies.

Also consider lowering minimal versions of dependencies if any of them overshoot.

@casey casey added this to the soon milestone Jul 8, 2019
@casey casey modified the milestones: soon, eventually Jul 11, 2019
@casey casey closed this as completed in #487 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant