Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on old version of kapp-controller, ytt should be removed #995

Open
jorgemoralespou opened this issue Aug 1, 2024 · 1 comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed

Comments

@jorgemoralespou
Copy link

jorgemoralespou commented Aug 1, 2024

When using kapp as library it adds:

What did you expect:
kapp-controller depends on kapp, and so kapp should not depend on kapp-controller.
Dependency on ytt and other libs should be upgraded so that they ingest carvel.dev instead


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@jorgemoralespou jorgemoralespou added bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been reviewed for validity labels Aug 1, 2024
@jorgemoralespou jorgemoralespou changed the title Dependency on old version of kapp-controller should be removed Dependency on old version of kapp-controller, ytt should be removed Aug 1, 2024
@100mik
Copy link
Contributor

100mik commented Aug 1, 2024

We should bump the ytt dependency. It is mainly used for ytt rebase rules.

The deal with kapp however is a bit different, kapp is consumed by kapp-controller as a binary, kapp just has a dependency on kapp-controller because it imports some types (pkgi/app primarily) to have some specific behaviour for these resources. But yep, it should be bumped if out of date 🙏🏼

@100mik 100mik added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed
Projects
Status: No status
Development

No branches or pull requests

2 participants