Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove member affiliation question; remove code question from SO and WI forms #2552

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Remove member affiliation question; remove code question from SO and WI forms #2552

merged 6 commits into from
Oct 26, 2023

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Oct 23, 2023

This comes from a discussion with the workshop admin team, as mentioned in #2380 (comment) .

@elichad elichad added this to the v4.3 milestone Oct 23, 2023
@elichad elichad self-assigned this Oct 23, 2023
@elichad elichad mentioned this pull request Oct 23, 2023
Merged
pbanaszkiewicz
pbanaszkiewicz reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments.

With the proposed migrations we're going to lose some data from DB. Is this something that the team is aware of and accepts?

amy/extrequests/forms.py
)
error_msg = (
"This code is invalid. "
"Please contact your Member Affiliate to verify your code."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected from someone submitting their form to know who "Member Affiliate" is? Can it be confused with someone on the core team?

If so, I'd add an explanation who Member Affiliate is, e.g.
"Please contact your Member Affiliate (usually a person distributing codes in your organization) to verify your code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this wording came from the workshops team, @sheraaronhurt what are your thoughts on Piotr's comment here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amy/extrequests/tests/test_workshop_requests.py Outdated Show resolved Hide resolved
@elichad
Copy link
Contributor Author

elichad commented Oct 25, 2023

The member_affiliation field was only added in #2532 to the feature/member_codes branch so there's no data in there.

I'll probably squash all the migrations on the feature/member_codes branch before merging into develop to clean all of this up a bit.

pbanaszkiewicz
pbanaszkiewicz approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elichad Thanks for explaining. I didn't notice this PR is not against develop branch. Since it's reverting the changes from feature/member-codes, I can approve it.

@elichad elichad merged commit aef7bad into feature/member-codes Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheraaronhurt sheraaronhurt sheraaronhurt left review comments

@pbanaszkiewicz pbanaszkiewicz pbanaszkiewicz approved these changes

Assignees

@elichad elichad

Labels
component: forms
Projects
Member code enforcement
Status: Done
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@elichad @pbanaszkiewicz @sheraaronhurt