Implement soft validation for member codes in training requests #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbanaszkiewicz
approved these changes
Oct 19, 2023
amy/extforms/forms.py
Outdated
| @@ -167,6 +171,10 @@ def set_accordion(self, layout: Layout) -> None: | |||
| ), | |||
| ) | |||
|
|
|||
| def set_display_member_code_override(self, visible: bool) -> None: | |||
There was a problem hiding this comment.
For functions that accept int or boolean arguments I prefer to make them required as keyword by using * in the function definition:
https://realpython.com/python-asterisk-and-slash-special-parameters/#in-short-the-python-asterisk-and-slash-control-how-to-pass-values-to-functions
There was a problem hiding this comment.
Oh interesting, I've never come across this syntax before. I see the appeal
amy/extforms/forms.py
Outdated
| # confirm that membership is currently active | ||
| # grace period: 90 days before and after | ||
| if not membership.active_on_date( | ||
| date.today(), grace_before=90, grace_after=90 | ||
| ): | ||
| errors["member_code"] = ValidationError(error_msg) | ||
| return False |
There was a problem hiding this comment.
I'd put just the line membership = Membership.objects.get(registration_code=code) inside of the try-except block. The conditional if not membership.active_on_date(...) could be outside of that block.
elichad
deleted the
feature/2535-Member-codes-Implement-soft-validation-for-member-codes
branch
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2535 by using option 2 - adding a checkbox to the form to override the code validation, and changing the visibility as necessary.
May also need to be applied to
TrainingRequestUpdateForm, but I need to check this with the instructor training team, so I'll make it a separate issue.