-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Discussion to Welcome Session, remove deprecated TrainingRequirements #2420
Changes from all commits
f02c991
cfe102d
01b5a5b
4bc5997
0fd20b1
037b8b9
22018e3
c19e99c
aa01217
105e577
bfc0e49
8b7f643
f1c784a
04196fb
a5708da
a6288ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# CI for feature branches - contains only test runs | ||
|
||
name: CI (feature) | ||
|
||
# don't run CI for every push of any feature branch | ||
# but do run CI if a PR is made with any feature branch as a base | ||
on: | ||
push: | ||
branches: [ 'feature/instructor-checkout-changes' ] | ||
pull_request: | ||
branches: [ 'feature/**' ] | ||
|
||
jobs: | ||
test: | ||
uses: ./.github/workflows/test.yml |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,14 @@ | |
# If an entry needs to be removed from the database, remove it from e.g. | ||
# `EMAIL_TEMPLATES`, and put its' ID in `DEPRECATED_EMAIL_TEMPLATES`. | ||
|
||
DEPRECATED_TRAINING_REQUIREMENTS: list[str] = [] | ||
DEPRECATED_TRAINING_REQUIREMENTS: list[str] = [ | ||
"DC Homework", | ||
"SWC Homework", | ||
"LC Homework", | ||
"DC Demo", | ||
"SWC Demo", | ||
"LC Demo", | ||
] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just want to make sure: were these migrated in production? I'm not sure what would happen if these were removed for existing users. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, I saw a migration removing these entries. We should not keep 2 systems for managing "static" (seeded) objects. I would suggest sticking to the seeding script, unless a data migration is actually required. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, I can remove that step from the migration. This is one thing I am uncertain of - are the seeding scripts run when deploying new versions to production? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good question. Let me see... I think they are not run during production deployment (but they definitely are run when deploying to test stage). We can run them manually after deploying to production, or make sure there's a step that runs them in Ansible. Once we switch to Docker-based production, we will run the seeds just like we do in test-amy. |
||
|
||
TrainingRequirementDef = TypedDict( | ||
"TrainingRequirementDef", | ||
|
@@ -22,13 +29,7 @@ | |
|
||
TRAINING_REQUIREMENTS: list[TrainingRequirementDef] = [ | ||
{"name": "Training", "url_required": False, "event_required": True}, | ||
{"name": "DC Homework", "url_required": True, "event_required": False}, | ||
{"name": "SWC Homework", "url_required": True, "event_required": False}, | ||
{"name": "Discussion", "url_required": False, "event_required": False}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Discussion" is not being deprecated as it's being switched to "Welcome Session". The migration |
||
{"name": "DC Demo", "url_required": False, "event_required": False}, | ||
{"name": "SWC Demo", "url_required": False, "event_required": False}, | ||
{"name": "LC Demo", "url_required": False, "event_required": False}, | ||
{"name": "LC Homework", "url_required": True, "event_required": False}, | ||
{"name": "Welcome Session", "url_required": False, "event_required": False}, | ||
{"name": "Lesson Contribution", "url_required": True, "event_required": False}, | ||
{"name": "Demo", "url_required": False, "event_required": False}, | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼