Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(InterstitialScreen): add typescript types #4969

Closed

Conversation

anamikaanu96
Copy link
Contributor

Contributes to #4486

Converted packages/ibm-products/src/components/InterstitialScreen/InterstitialScreen.js to packages/ibm-products/src/components/InterstitialScreen/InterstitialScreen.tsx

What did you change? packages/ibm-products/src/components/InterstitialScreen/InterstitialScreen.tsx

How did you test and verify your work? Storybook

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner April 23, 2024 08:47
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit db52e08
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/663875392551140008d6be0c
😎 Deploy Preview https://deploy-preview-4969--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anamikaanu96 anamikaanu96 linked an issue Apr 23, 2024 that may be closed by this pull request
Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you just have a conflict to resolve before merging.

@anamikaanu96 anamikaanu96 deleted the InterstitialScreen branch May 6, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript types to InterstitialScreen
2 participants