From a4780450326592f5624397310f90b7599e4a0fbf Mon Sep 17 00:00:00 2001
From: Peter Makowski <peter.makowski@canonical.com>
Date: Thu, 29 Feb 2024 11:42:32 +0100
Subject: [PATCH] fix: kvm support message for virsh only lp#2053096 (#5325)

---
 .../DeployFormFields.test.tsx                 | 35 +++++++++++++++++++
 .../DeployFormFields/DeployFormFields.tsx     |  6 +++-
 2 files changed, 40 insertions(+), 1 deletion(-)

diff --git a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx
index fe186821ee..a0187987fa 100644
--- a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx
+++ b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx
@@ -364,6 +364,41 @@ describe("DeployFormFields", () => {
     expect(screen.getByRole("radio", { name: /libvirt/ })).toBeInTheDocument();
   });
 
+  it("displays support message only when 'virsh' is selected for KVM host type", async () => {
+    if (state.general.osInfo.data) {
+      state.general.osInfo.data.default_release = "bionic";
+    }
+    const store = mockStore(state);
+    render(
+      <Provider store={store}>
+        <MemoryRouter
+          initialEntries={[{ pathname: "/machines/add", key: "testKey" }]}
+        >
+          <CompatRouter>
+            <DeployForm
+              clearSidePanelContent={vi.fn()}
+              machines={[]}
+              processingCount={0}
+              viewingDetails={false}
+            />
+          </CompatRouter>
+        </MemoryRouter>
+      </Provider>
+    );
+
+    const SUPPORT_MESSAGE =
+      "Only Ubuntu 18.04 LTS and Ubuntu 20.04 LTS are officially supported.";
+
+    await userEvent.click(
+      screen.getByRole("checkbox", { name: /Register as MAAS KVM host/ })
+    );
+    await userEvent.click(screen.getByRole("radio", { name: /libvirt/ }));
+    expect(screen.getByText(SUPPORT_MESSAGE)).toBeInTheDocument();
+
+    await userEvent.click(screen.getByRole("radio", { name: /LXD/ }));
+    expect(screen.queryByText(SUPPORT_MESSAGE)).not.toBeInTheDocument();
+  });
+
   it("displays a warning if user has no SSH keys", () => {
     if (state.user.auth.user) {
       state.user.auth.user.sshkeys_count = 0;
diff --git a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx
index 843f7525d7..0991b01be1 100644
--- a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx
+++ b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx
@@ -174,7 +174,11 @@ export const DeployFormFields = (): JSX.Element => {
                 <Input
                   checked={deployVmHost}
                   disabled={!canBeKVMHost || noImages}
-                  help="Only Ubuntu 18.04 LTS and Ubuntu 20.04 LTS are officially supported."
+                  help={
+                    values.vmHostType === PodType.VIRSH
+                      ? "Only Ubuntu 18.04 LTS and Ubuntu 20.04 LTS are officially supported."
+                      : undefined
+                  }
                   id="deployVmHost"
                   label={
                     <>