fix: introduce uri validation for params

canonical · Mar 26, 2024 · 5eecee4 · 5eecee4
1 parent e6dbf32
commit 5eecee4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/pkg/idp/handlers.go b/pkg/idp/handlers.go
@@ -24,10 +24,10 @@ type API struct {
 
 func (a *API) RegisterEndpoints(mux *chi.Mux) {
 	mux.Get("/api/v0/idps", a.handleList)
-	mux.Get("/api/v0/idps/{id}", a.handleDetail)
+	mux.Get("/api/v0/idps/{id:.+}", a.handleDetail)
 	mux.Post("/api/v0/idps", a.handleCreate)
-	mux.Patch("/api/v0/idps/{id}", a.handlePartialUpdate)
-	mux.Delete("/api/v0/idps/{id}", a.handleRemove)
+	mux.Patch("/api/v0/idps/{id:.+}", a.handlePartialUpdate)
+	mux.Delete("/api/v0/idps/{id:.+}", a.handleRemove)
 }
 
 func (a *API) handleList(w http.ResponseWriter, r *http.Request) {

diff --git a/pkg/schemas/handlers.go b/pkg/schemas/handlers.go
@@ -25,10 +25,10 @@ type API struct {
 
 func (a *API) RegisterEndpoints(mux *chi.Mux) {
 	mux.Get("/api/v0/schemas", a.handleList)
-	mux.Get("/api/v0/schemas/{id}", a.handleDetail)
+	mux.Get("/api/v0/schemas/{id:.+}", a.handleDetail)
 	mux.Post("/api/v0/schemas", a.handleCreate)
-	mux.Patch("/api/v0/schemas/{id}", a.handlePartialUpdate)
-	mux.Delete("/api/v0/schemas/{id}", a.handleRemove)
+	mux.Patch("/api/v0/schemas/{id:.+}", a.handlePartialUpdate)
+	mux.Delete("/api/v0/schemas/{id:.+}", a.handleRemove)
 	mux.Get("/api/v0/schemas/default", a.handleDetailDefault)
 	mux.Put("/api/v0/schemas/default", a.handleUpdateDefault)
 }