-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for #5, #6 and #7; includes README update #8
Conversation
…des README update
Thanks for your contribution. About the new options you have introduced, do you really need to customize the error messages? |
Regarding the additional options: From a prospective of MVP (Minimum viable product) the additional options I do technically don't need them. There are 2 additional considerations though:
Bottom line:
|
|
||
// store parent file path to check circular references | ||
if (parentFilePath) { | ||
filesProcessed.push(parentFilePath); | ||
} | ||
while ((cap = includeRe.exec(src))) { | ||
filePath = path.resolve(rootdir, cap[1].trim()); | ||
mdSrc = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have used a new variable to handle the error message. Like errorMessage
.
c428e11
to
f906a34
Compare
As I did submit the issues #5, #6 and #7 I figured I also propose a solution.
The reason behind bringing this up is because I'm using this NPM package in a VSCode extension to improve the Markdown Preview: Markdown Preview Include Support ... will add a "Credits" note to this project as well with the next release.
Hope my proposal's help - thanks a lot in advance for consideration :-)