Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover style API: variable border radius #69

Closed
okwasniewski opened this issue Jan 11, 2024 · 10 comments
Closed

Hover style API: variable border radius #69

okwasniewski opened this issue Jan 11, 2024 · 10 comments
Labels
enhancement New feature or request

Comments

@okwasniewski
Copy link
Member

okwasniewski commented Jan 11, 2024

Description

The goal of this issue is to adapt hoverStyle API to properly use variable corner radius for each corner of the view. This is a continuation of the work done in #66

@okwasniewski okwasniewski added the enhancement New feature or request label Jan 11, 2024
@okwasniewski
Copy link
Member Author

@gokul1099 Created an issue for the feature you was working on

@gokul1099
Copy link

@okwasniewski looks like PR #66 is broken and not working now. Can you check once.

@gokul1099
Copy link

@okwasniewski while working for PR #66 I made all the changes in RCTViewComponentView file and it works. But after recent commits any changes in RCTViewComponentView is not reflecting. I even added breakpoint and it's not working.
Any recent changes are causing this ? Any idea on this ??

@okwasniewski
Copy link
Member Author

@gokul1099 Can you try installing pods with RCT_NEW_ARCH_ENABLED=1 flag? Recently in core they changed that RNTester is not building with new arch by default

@gokul1099
Copy link

@gokul1099 Can you try installing pods with RCT_NEW_ARCH_ENABLED=1 flag? Recently in core they changed that RNTester is not building with new arch by default

oh ok, let me try

@gokul1099
Copy link

@gokul1099 Can you try installing pods with RCT_NEW_ARCH_ENABLED=1 flag? Recently in core they changed that RNTester is not building with new arch by default

I tried this still not working

@okwasniewski
Copy link
Member Author

@gokul1099 Another change I missed upstream is that we are now running Bridgeless mode by default. This PR fixes hoverStyle for bridgeless mode: #92, so you should be now able to see your breakpoints

@gokul1099
Copy link

@okwasniewski I don't think this is specific to hoverStyle prop. Currently none of the methods in the RCTViewComponentView is being invoked.

@okwasniewski
Copy link
Member Author

This feature has been tackled by @Saadnajmi in this PR: facebook#43078 - which will be soon cherry-picked to react-native-visionos

@okwasniewski
Copy link
Member Author

fixed by: #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants