Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.exe should not be used for Tools & Addin directive on CoreCLR #1183

Closed
devlead opened this issue Aug 24, 2016 · 12 comments
Closed

NuGet.exe should not be used for Tools & Addin directive on CoreCLR #1183

devlead opened this issue Aug 24, 2016 · 12 comments
Labels

Comments

@devlead
Copy link
Member

devlead commented Aug 24, 2016

Currently NuGet.exe isn't CoreCLR compatible so we should download tools/addins same way we download the Roslyn compilers.

@devlead devlead added this to the v0.16.0 milestone Aug 24, 2016
@patriksvensson patriksvensson self-assigned this Aug 29, 2016
@patriksvensson
Copy link
Member

We have decided to postpone this until NuGet.PackageManagement is supported on CoreCLR.

Workaround (for now)

Add a project.json with the packages you want to install and use dotnet restore --packages "./tools" in your bootstrapper.

@patriksvensson patriksvensson removed this from the v0.16.0 milestone Aug 29, 2016
@patriksvensson patriksvensson removed their assignment Aug 30, 2016
@adamhathcock
Copy link
Contributor

I made this build.sh for myself https://gist.github.com/adamhathcock/87c7cad21916fe871dc6fd09b5dea715

This expects the project.json in tools like @patriksvensson suggested

Note there's a CAKE_VERSION and CAKE_FEED to get the early builds.

@vlesierse
Copy link
Contributor

vlesierse commented Sep 20, 2016

@adamhathcock, @patriksvensson thanks for your Gist. Currently I'm trying to run my build.cake using your solution but I end up with the error message. Any directions? BTW, this is only when in the 0.16.0 release of the Cake.CoreCLR package.

Error: assembly specified in the dependencies manifest was not found -- package: 'System.Collections.NonGeneric', version: '4.0.1', path: 'lib/netstandard1.3/System.Collections.NonGeneric.dll'

@gep13
Copy link
Member

gep13 commented Sep 20, 2016

@vlesierse this is a known issue. Keep an eye out for the 0.16.1 hotfix release in the next couple days to address this.

@vlesierse
Copy link
Contributor

@gep13 Thnx, I wait for the release. Just as I typed this I noticed this issue ... #1237

@vlesierse
Copy link
Contributor

If you are interested I got a Gist for creating the project.json file from the bash script
build.sh

@phenixdotnet
Copy link
Contributor

Hi.
Is there any update on this ?
The NuGet.PackageManagement project doesn't support .NET Core yet and the project.json workaround doesn't work anymore.

As a 'fix" can we check if the current platform is Unix and if yes, change the command to use mono ? Is that acceptable ?

@devlead
Copy link
Member Author

devlead commented Jul 13, 2017

We've just recently ported Cake to 1.0.4 SDK and csproj, are just finishing up getting cake tooling aliases up to speed with the new SDK and current priority post that is to get Cake up to speed with the latest Roslyn bits. So we've just not had the time to look at this yet.

Don't think adding a hard dependency to mono is the way to for .NET Core version of Cake.

We should look at some .NET Core native way if doing this, perhaps as a PoC module.

Possible work arounds are to use

  • use packages.config for addins/tools/modules
  • create executable bash script mimicking or invocing nuget install command
  • curl & unzip nuget packages without the need for mono or nuget.exe

@bjorkstromm
Copy link
Member

#1768 allows opportunity to use a in-process NuGet client instead of shelling out to nuget.exe.

@adamhathcock
Copy link
Contributor

I guess #1768 doesn't cover add-ins?

@devlead
Copy link
Member Author

devlead commented Sep 24, 2017

@adamhathcock it does

@augustoproiete
Copy link
Member

Closed as #wont-fix given that the CoreCLR runner has been deprecated.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants