New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report must be public ? #39

Open

fridobox opened this issue Nov 20, 2020 · 1 comment

Contributor

fridobox commented Nov 20, 2020

Hi

Reading doc I see report(s) must be public :
https://github.com/bywatersolutions/koha-plugin-coverflow/blob/master/README.md#generate-a-public-report

Looks like it works even if private report.

Is it on purpose ?

koha-plugin-coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm

Line 261 in 4a1819c

#die "Sorry this report is not public\n" unless $report_rec->{public};

Contributor

minusdavid commented Jun 25, 2021

Ohhh that's interesting. I thought they were still using the old report API. That's probably just old documentation then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment