Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid might call setState in componentWillUpdate #585

Closed
wasd171 opened this issue Feb 20, 2017 · 4 comments
Closed

Grid might call setState in componentWillUpdate #585

wasd171 opened this issue Feb 20, 2017 · 4 comments

Comments

@wasd171
Copy link

wasd171 commented Feb 20, 2017

Hello!

Grid might call setState during componentWillUpdate lifecycle via _setScrollPosition, which is, according to React documentation, forbidden.

I caught this error when trying to use ScrollSync with 2 active controlling components.

I believe it's a bug, perhaps you wanted to use componentWillReceiveProps instead?
@bvaughn
Copy link
Owner

bvaughn commented Feb 20, 2017

Good observation @wasd171

@wasd171
Copy link
Author

wasd171 commented Feb 20, 2017

I believe this might be an issue for CollectionView too

@bvaughn
Copy link
Owner

bvaughn commented Feb 20, 2017

Fixed in 38b3a40, released in 9.0.2. Thanks for pointing this out.

@bvaughn bvaughn closed this as completed Feb 20, 2017
@wasd171
Copy link
Author

wasd171 commented Feb 21, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvaughn @wasd171