Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Removal] - Deprecate Fragments #2883

Closed
jaredsburrows opened this issue Feb 7, 2018 · 3 comments
Closed

[Feature Removal] - Deprecate Fragments #2883

jaredsburrows opened this issue Feb 7, 2018 · 3 comments
Labels
enhancement help wanted

Comments

@jaredsburrows
Copy link
Contributor

Based on @JakeWharton's post: android/android-ktx#161 (comment).

Usages are here: https://github.com/bumptech/glide/search?utf8=%E2%9C%93&q=%22android.app.Fragment%22&type=

I believe you should add @Deprecated then in a next major version, prune them. What do you think @TWiStErRob?
@sjudd
Copy link
Collaborator

sjudd commented Feb 8, 2018

I don't think there's any rush here. It may take a while for users to migrate to the support library fragments and adding deprecation warnings to their existing deprecation warnings probably isn't super valuable?

I wouldn't be opposed to a pull request.

@jaredsburrows jaredsburrows mentioned this issue Feb 8, 2018
Closed
@jaredsburrows
Copy link
Contributor Author

Thanks. Here is the PR: #2886.

@jaredsburrows
Copy link
Contributor Author

@sjudd Are we still migrating this to support or Android X Fragments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjudd @jaredsburrows