Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Gorilla websockets package #134

Closed
davecgh opened this issue Jun 7, 2014 · 0 comments
Closed

Switch to Gorilla websockets package #134

davecgh opened this issue Jun 7, 2014 · 0 comments

Comments

@davecgh
Copy link
Member

davecgh commented Jun 7, 2014

There are some issues with the go.net websockets package such as the lack of support for generating ping websocket protocol messages to help keep the connection alive and the requirement to cast between strings and []byte (causing extra allocations and mem copies) to determine the frame type.

In practice, these issues don't prevent the current code from working, but the recent btcrpcclient changes already make use of the Gorilla websocket package and work is underway to also convert btcwallet to use the package as well. This will help keep the code consistent as well as make it slightly more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant