Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure connect callback is invoked on premature socket hangup #542

Closed
wants to merge 2 commits into from
Closed

Ensure connect callback is invoked on premature socket hangup #542

wants to merge 2 commits into from

Conversation

strk
Copy link
Contributor

@strk strk commented Mar 17, 2014

Closes #534

The patch was tested against 2.11.1

@strk strk mentioned this pull request Mar 17, 2014
Closed
Remove disconnected clients from the pool
7e2e87d 
Might fix brianc#458
Fixes CartoDB/CartoDB-SQL-API#135
Avoids loop between pool.destroy and client.end
@strk
Copy link
Contributor Author

strk commented Mar 18, 2014

It actually only fixes #534 with node-0.10, giving this trace to the test included in the bug report:

server listening
client connecting
server connected
server socket destroyed.
server closed
Error on connect: Error: Stream unexpectedly ended before getting ready for query execution

Doesn't fix it with node-0.8, looking at why.

@strk strk mentioned this pull request Mar 18, 2014
Merged
@strk
Copy link
Contributor Author

strk commented Mar 18, 2014

Deprecated by #546

@strk strk closed this Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pg doesn't invoke callback if server accepts the connection and immediately disconnects
1 participant
@strk