Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] feature: close split view automatically #10166

Open
core-ai-bot opened this issue Aug 30, 2021 · 3 comments
Open

[CLOSED] feature: close split view automatically #10166

core-ai-bot opened this issue Aug 30, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by zaggino
Saturday Sep 26, 2015 at 03:00 GMT
Originally opened as adobe/brackets#11746


steps:

  1. open preferences file
  2. split view opens
  3. click to close the brackets.json in the right pane, nothing else is remaining in the right pane

i believe, that the split view should now close automatically, given it was also automatically opened

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Saturday Sep 26, 2015 at 09:23 GMT


Makes sense in the preferences scenario, but in general I think that the preferences split view should be more isolated anyway. Auto-closing the panel when it's possible to modify the views while the preferences are open is a bit tricky too. Consider something like this:

  1. Open preferences file
  2. Split view opens
  3. Drag another file to right panel
  4. Close brackets.json -> Right view should stay open right?

But what if

  1. Drag the file back to left panel
  2. Close brackets.json - nothing stays in the right panel but it shouldn't auto close as it has been "dirty" - right?

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Saturday Sep 26, 2015 at 12:02 GMT


Well, I'd implement it in a way that if split-view was automatically opened it also should automatically close. If it was opened manually, it should never auto-close. I don't really like split view and how it's forcing itself anytime I want to change something in preferences.

@core-ai-bot
Copy link
Member Author

Comment by petetnt
Thursday Feb 16, 2017 at 14:21 GMT


This was added in #11749 right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant