New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the HTTP Client code to match the latest ESP8266 examples #3

Open

bneedhamia opened this issue Dec 19, 2019 · 0 comments

Assignees

Labels

Owner

bneedhamia commented Dec 19, 2019

Currently the HTTPClient object is created once, and reused. From the example at https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266WiFi/examples/WiFiClient/WiFiClient.ino it seems the client should be created once per HTTP request. Looking at the source for HTTPClient, it seems constructing it begins some work.

Taking this into consideration, it sounds like HTTPClient should be moved at least into loop() so it is not reused.

bneedhamia self-assigned this

bneedhamia added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment