Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact jump table #389

Closed
rakita opened this issue Feb 26, 2023 · 0 comments · Fixed by #391
Closed

Compact jump table #389

rakita opened this issue Feb 26, 2023 · 0 comments · Fixed by #391

Comments

@rakita
Copy link
Member

rakita commented Feb 26, 2023

Make compact jumpable as it is now just vec of bool. (Current vec of u32 jumpdest bit | block gas but block gas is going to be removed here #388)

Idea of it being compact is to save space but allow fast reads. Every bytecode position should be a bit of the u8,

And it should replace this function:
https://github.com/bluealloy/revm/blob/main/crates/primitives/src/bytecode/jump_table.rs#L77-L82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove gas blocks onbjerg/revm
1 participant
@rakita