This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Allow collection scopes as valid during auth #1973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1969 , if you pass a collection scope, the current production browser will block the authentication request because it has an invalid scope. I've changed that to allow collection scopes.
I also fixed a bug where the
validateScopes
function only returnedfalse
if the last scope was invalid - if you passed scopes like['invalid', 'store_write']
then the function would pass.You can test this with https://planet.friedger.de/ , which requests the 'contacts' scope.