Renew Blockstack IDs #1938

yknl · 2019-07-02T13:43:07Z

This PR adds name expiry information and basic name renewal feature. Full on-chain names that have less than 60 days until expiration will see a renew button beside it. The renewal transaction will be funded by the built-in BTC wallet.

This is based on a previous PR from @friedger to display expiry information in the all profiles screen.

Renew UI in all profiles screen

Subdomains do not need to be renewed

Testing notes

Find a name that has less than 60 days until expiration.
Go to the all profiles screen.
Click renew.
Enter password and press renew.
Wait for transaction to confirm x 10.
Verify that domain name now has many more days until expiration.

hstove · 2019-09-06T22:13:03Z

Find a name that has less than 60 days until expiration.

This has to be my name? I don't have any names that are that old.

yknl · 2019-09-07T19:16:36Z

You can also test it by making a temporary change, making 60 days limit 600.

https://github.com/blockstack/blockstack-browser/blob/4f14ba7800b676aacad7c0839ff0b79adfffc922/app/js/profiles/components/IdentityItem.js#L154

hstove

I tested this out. I successfully generated a renew transaction. However, I only saw the transaction ID after renewing. I wasn't sure if that was me signing the TX, or actually submitting it. I clicked 'renew' again, assuming it would then submit the TX. Turns out that I renewed it twice :)

I would recommend changing the UX a bit by:

Disabling the 'renew' button after successfully submitting a renewal.
Adding a message that the TX has been submitted, and you should check your identities page in ~1 hour (?) to ensure that the expiration date has been updated

hstove · 2019-09-11T20:55:33Z

I would also recommend some 'confirm' step before submitting the actual TX. I had no idea what the cost was going to be

markmhendrickson · 2019-09-16T16:52:23Z

@yknl were you able to incorporate @hstove's suggested changes? They sound helpful to me. Otherwise, this looks functionally like a good addition to me. And I'm wondering if @timstackblock should QA before we go live.

yknl · 2019-09-16T17:25:44Z

@hstove is going to take a stab at improving the UX when he gets a chance

timstackblock · 2019-09-17T17:18:02Z

@markmhx I can take a look is this issue pulled into a zenhub board and ready for QA, I dont see it anywhere?

markmhendrickson · 2019-09-18T10:24:23Z

@timstackblock It sounds from @yknl that @hstove needs to make some UX changes then he'll move this from "In Progress" to "Review / QA" on ZenHub.

timstackblock · 2019-09-18T14:47:55Z

Sure no problem just @ me when you are ready and I will jump right on it.

diwakergupta · 2019-11-04T14:13:44Z

@hstove @markmhx any update here? More and more people are going to run into name expiration.

markmhendrickson · 2019-11-04T16:10:09Z

@diwakergupta I've made a note to discuss this during our weekly kick-off tomorrow.

However, iirc we last decided (over the summer) to keep this effort relatively de-prioritized despite the expectation that names will continue to expire since we don't have a reliable way to reach out to users prompting them to renew (e.g. via email). As such, any UX improvements to make renewals easier will have minimal impact.

moxiegirl · 2019-11-13T17:06:51Z

@yknl Thanks. I knew how to get to the test page, it was having an id to test with that appeared to require a rebuild. Further, users can only renew with a renewable ID. And the blockstack ID is not renewable because there is no expiration, here is the error I am getting.

So, I have to buy an id in order to test this process or get an ID to test with.

moxiegirl · 2019-11-13T17:45:19Z

Information related to renewal

first class identity is what we want to call this thing created sub to someone's Blockstack id.
This interface only renews .id identities
For non .id renewals users must use the command line
If you do not renew it someone else can renew the name in the grace priod
If you forget to renew, you have a grace period is two months; if you miss the grace period you have to re-regiser

Testing Tips from Ken

If you want to verify that the work make sure the name goes through.
Renew transaction new block will move out.

cc: @yknl please check

yknl · 2019-11-13T20:09:30Z

first class identity is what we want to call this thing created sub to someone's Blockstack id.

I'm not sure we've settled on this, it seems like a larger product decision. I recommend not emphasizing this for now.

For non .id renewals users must use the command line

For renewing any ID not in the .id namespace, you will need to use the Blockstack CLI tool

If you do not renew it someone else can renew the name in the grace priod

No, only the owner can renew the name during the grace period.

If you want to verify that the work make sure the name goes through.
Renew transaction new block will move out.

For internal testing, you can check that the expire_block of the name has changed to a later block after a renewal transaction has been confirmed.
https://core.blockstack.org/v1/names/blockstacker.id

hstove · 2019-11-13T22:56:35Z

Changes I've made:

First, there is a pre-step to get the estimated price, before you actual send the TX:

Then, I added a note that it might take 2 hours to process, and also disabled the "renew" button after it went through.

hstove · 2019-11-13T22:58:57Z

For reviewers:

First, you need a "first class domain", as we called it, aka a name like myname.id. Visit the 'identities' page, then click 'more'. Then, you should see a message around how long until it expires, with a renew button next to it, as shown earlier in this ticket. Click the renew button to go to this page.

You need BTC to register a name and renew it. Reach out to me if you need some for testing purposes.

For testing, I've changed the logic to allow you to renew your name even if it's 2 years away. Previously, we set that to 60 days. We should consider what we want that threshold to actually be when we release it.

moxiegirl

@markmhx Here are my review comments.

moxiegirl · 2019-11-19T03:18:08Z

app/js/profiles/AllProfilesPage.js

@@ -224,8 +228,8 @@ class AllProfilesPage extends Component {
            </div>
            <div className="row m-t-20">
              <p className="col form-text text-muted">
-                Have you recovered and are missing IDs? Just add them
-                back by using the "Add another ID" for each ID.
+                Have you recovered and are missing IDs? Just add them back by


What does recovered mean here? Recovered from what? Or is it possible to both recover and be missing an ID? Maybe you want to say:

Are you missing IDs after restoring the browser? Use Add another ID for each ID you want to add back.

moxiegirl · 2019-11-19T03:19:19Z

app/js/profiles/RenewNamePage.js

+      return 'Renew'
+    }
+    if (estimateInProgress) {
+      return 'Generating estimated cost'


Estimating the purchase price. Price is subject to fluctuations in the price of BTC.

This is the button copy - I think that's too long to put in a button. When the estimate is generated, it says "Renewing your name will cost roughly XXX BTC"

moxiegirl · 2019-11-19T03:20:22Z

app/js/profiles/RenewNamePage.js

+              {this.state.error ? <div className="alert alert-danger">{this.state.error}</div> : null}
+              {success && <div className="alert alert-success">
+                <p>{success}</p>
+                <p style={{ marginBottom: 0 }}>Your renewal might take up to two hours to process</p>


Processing your renewal can take up to two hours.

If you don't like the rephrase, at least take a period for consistency

moxiegirl · 2019-11-19T03:22:25Z

app/js/profiles/TransferNamePage.js

                <p>
-                Transfer ownership is an advanced feature. It requires broadcasting a
-                transaction on Bitcoin network and costs Bitcoin.
+                  Transfer ownership is an advanced feature. It requires


Transferring the ownership of a name is an advanced feature. Ownership transfer requires broadcasting a transaction on the Bitcoin network; Transactions cost Bitcoin (BTC).

or

Transferring the ownership of a name is an advanced feature. Ownership transfer requires modifying a name's zone file and broadcasting an update transaction with this change on the Bitcoin network. You must pay for the transaction costs in Bitcoin (BTC).

moxiegirl · 2019-11-19T03:25:51Z

app/js/profiles/ZoneFilePage.js

-        this.updateAlert('success', 'Broadcasting zone file update transaction...')
+        this.updateAlert(
+          'success',
+          'Broadcasting zone file update transaction...'


Broadcasting name transfer update transaction.

We didn't previously mention the zone file. Are users actually likely to understand what a zone file is? If you use the text I gave you about the zone file up above, then STET this.

moxiegirl · 2019-11-19T03:26:58Z

app/js/profiles/ZoneFilePage.js

-                Updating your zone file is an advanced feature that can break
-                your Blockstack name and profile. It requires broadcasting a
-                transaction on Bitcoin network and costs Bitcoin.
+                  Updating your zone file is an advanced feature that can break


Why didn't we mention "breaking" above? Maybe just go for consistency and stick with this text:

Transferring the ownership of a name is an advanced feature. Ownership transfer requires modifying a name's zone file and broadcasting an update transaction with this change on the Bitcoin network. You must pay for the transaction costs in Bitcoin (BTC).

or if we should mention this, this is clearer.

Transferring the ownership of a name is an advanced feature. Ownership transfer requires modifying a name's zone file and broadcasting an update transaction with this change on the Bitcoin network. Further, transfers can fail and leave your name in a state where you can no longer use it. You must pay for the transaction costs in Bitcoin (BTC) regardless of whether the transaction succeeds or fails.

moxiegirl · 2019-11-19T03:32:34Z

app/js/profiles/ZoneFilePage.js

-                      I understand this could break my Blockstack
-                      name and will cost me money.
+                      I understand this could break my Blockstack name and will
+                      cost me money.


Yes, I understand I am requesting an ownership transfer of name NAMEHERE. Further, I understand that the transfer can fail leaving my name unavailable. Regardless of whether the owner transfer transaction fails or succeeds, I am required to pay transaction fees in Bitcoin (BTC).

moxiegirl · 2019-11-19T03:34:20Z

app/js/profiles/store/registration/actions.js

@@ -224,7 +289,7 @@ const registerName = (
            'apps may be unusable until you do.'
          if (res.status === 409) {
            message =
-              "Sorry, it looks like we weren't able to process your name registration. Please contact us at support@blockstack.org for help. Some apps may be unusable until you register an ID."
+              'Sorry, it looks like we weren\'t able to process your name registration. Please contact us at support@blockstack.org for help. Some apps may be unusable until you register an ID.'


'Sorry, it looks like the blockchain failed to process your name registration. Please contact us at support@blockstack.org for help. Some apps may be unusable until you register an ID.'

This ^^^ is more decentralized language "we were able to process" makes it look like a central authority.

moxiegirl · 2019-11-19T03:34:33Z

app/js/profiles/store/registration/actions.js

@@ -251,7 +316,7 @@ const registerName = (
          'apps may be unusable until you do.'
        if (e.status === 409) {
          message =
-            "Sorry, it looks like we weren't able to process your name registration. Please contact us at support@blockstack.org for help. Some apps may be unusable until you register an ID."
+            'Sorry, it looks like we weren\'t able to process your name registration. Please contact us at support@blockstack.org for help. Some apps may be unusable until you register an ID.'


'Sorry, it looks like the blockchain failed to process your name registration. Please contact us at support@blockstack.org for help. Some apps may be unusable until you register an ID.'

hstove · 2019-11-20T00:14:57Z

Thanks @moxiegirl , great feedback! I've updated the copy to what you've suggested.

friedger and others added 9 commits May 28, 2019 13:06

add expiry date in AllProfilePage

e1c3f29

correct block to day conversion

09a339f

fix lint: duplicate import

ecd1013

fix transfer nanme and update zone file page

ebf1e71

replace back button

9e827a1

fix lint and flow issues

638987b

update tests for expireBlock and tooltip

ea86a15

Add ability to send name renew transactions.

dbf989e

Fix lint.

97c8679

yknl changed the title ~~Renew Blockstack IDs~~ [WIP] Renew Blockstack IDs Jul 2, 2019

markmhendrickson mentioned this pull request Jul 2, 2019

Add expiry information for names #1924

Merged

yknl added 3 commits August 8, 2019 16:12

Renew with empty zonefile.

e57a852

Merge branch 'develop' into feature/name-renew

65293e8

Renew with empty zonefile fix.

4f14ba7

yknl changed the title ~~[WIP] Renew Blockstack IDs~~ Renew Blockstack IDs Aug 30, 2019

yknl requested review from hstove and markmhendrickson August 30, 2019 18:44

hstove suggested changes Sep 11, 2019

View reviewed changes

markmhendrickson mentioned this pull request Sep 16, 2019

Add estimated expiration time of names. stacks-archive/blockstack-explorer#29

Closed

moxiegirl added the Impacts DOCS Requires new or updates to our documentation. label Sep 19, 2019

hstove added this to the Browser 0.37 milestone Nov 12, 2019

moxiegirl closed this Nov 13, 2019

moxiegirl reopened this Nov 13, 2019

hstove self-assigned this Nov 13, 2019

hstove added 4 commits November 13, 2019 14:50

adds estimation step before renewing

87465f8

for testing, allow estimates even if expiration is 2 years away

eb2bddc

allow renewing up to 750 days early

3019380

eslint auto-fixes in registration actions

b5db9db

hstove assigned timstackblock and unassigned hstove Nov 13, 2019

allow trying to renew again if there is an error

70efd9f

markmhendrickson requested review from timstackblock and moxiegirl November 18, 2019 13:58

moxiegirl reviewed Nov 19, 2019

View reviewed changes

hstove mentioned this pull request Nov 19, 2019

v0.37.0 #1981

Merged

hstove assigned hstove and unassigned moxiegirl and timstackblock Nov 19, 2019

updated copy from Mary's feedback

d88963e

hstove assigned moxiegirl and timstackblock and unassigned hstove Nov 20, 2019

hstove approved these changes Nov 20, 2019

View reviewed changes

hstove merged commit 2afbc32 into develop Nov 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renew Blockstack IDs #1938

Renew Blockstack IDs #1938

yknl commented Jul 2, 2019 •

edited

Loading

hstove commented Sep 6, 2019

yknl commented Sep 7, 2019

hstove left a comment

hstove commented Sep 11, 2019

markmhendrickson commented Sep 16, 2019 •

edited

Loading

yknl commented Sep 16, 2019

timstackblock commented Sep 17, 2019

markmhendrickson commented Sep 18, 2019

timstackblock commented Sep 18, 2019

diwakergupta commented Nov 4, 2019

markmhendrickson commented Nov 4, 2019

moxiegirl commented Nov 13, 2019 •

edited

Loading

moxiegirl commented Nov 13, 2019 •

edited

Loading

yknl commented Nov 13, 2019

hstove commented Nov 13, 2019

hstove commented Nov 13, 2019

moxiegirl left a comment

moxiegirl Nov 19, 2019

moxiegirl Nov 19, 2019

hstove Nov 20, 2019

moxiegirl Nov 19, 2019

moxiegirl Nov 19, 2019

moxiegirl Nov 19, 2019

moxiegirl Nov 19, 2019

moxiegirl Nov 19, 2019

moxiegirl Nov 19, 2019

moxiegirl Nov 19, 2019

hstove commented Nov 20, 2019

Renew Blockstack IDs #1938

Renew Blockstack IDs #1938

Conversation

yknl commented Jul 2, 2019 • edited Loading

Testing notes

hstove commented Sep 6, 2019

yknl commented Sep 7, 2019

hstove left a comment

Choose a reason for hiding this comment

hstove commented Sep 11, 2019

markmhendrickson commented Sep 16, 2019 • edited Loading

yknl commented Sep 16, 2019

timstackblock commented Sep 17, 2019

markmhendrickson commented Sep 18, 2019

timstackblock commented Sep 18, 2019

diwakergupta commented Nov 4, 2019

markmhendrickson commented Nov 4, 2019

moxiegirl commented Nov 13, 2019 • edited Loading

moxiegirl commented Nov 13, 2019 • edited Loading

Information related to renewal

Testing Tips from Ken

yknl commented Nov 13, 2019

hstove commented Nov 13, 2019

hstove commented Nov 13, 2019

moxiegirl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hstove commented Nov 20, 2019

yknl commented Jul 2, 2019 •

edited

Loading

markmhendrickson commented Sep 16, 2019 •

edited

Loading

moxiegirl commented Nov 13, 2019 •

edited

Loading

moxiegirl commented Nov 13, 2019 •

edited

Loading