Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: husky hooks not being installed on blitz new #506

Closed
flybayer opened this issue Apr 29, 2020 · 2 comments · Fixed by blitz-js/blitz#399
Closed

Bug: husky hooks not being installed on blitz new #506

flybayer opened this issue Apr 29, 2020 · 2 comments · Fixed by blitz-js/blitz#399

Comments

@flybayer
Copy link
Member

What is the problem?

Husky hooks aren't being installed for new apps because the git repo is being initialized after dependency install

Steps to Reproduce:

  1. blitz new myapp
  2. Change a file
  3. Commit the the change
  4. Notice the pre-commit hook doesn't run

Versions:

Latest canary

Possible fix

I think we need to run git init before dependencies are installed, but then run the initial git commit after they are installed (to have the lock file in the first commit)

@peaonunes
Copy link
Contributor

I would be happy to collaborate on that 😄

@merelinguist
Copy link
Contributor

@peaonunes Awesome! Have a look at our contributing guide, and then feel free to create a pull request when you’re ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment