[#135] check latest version for builder/tester dependencies

blablacar · May 19, 2016 · 6202873 · 6202873
1 parent 47dfef0
commit 6202873
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/bin-dgr/aci.go b/bin-dgr/aci.go
@@ -159,15 +159,22 @@ func (aci *Aci) checkCompatibilityVersions() {
 }
 
 func (aci *Aci) checkLatestVersions() {
-	for _, dep := range aci.manifest.Aci.Dependencies {
+	CheckLatestVersion(aci.manifest.Aci.Dependencies, "dependency")
+	CheckLatestVersion(aci.manifest.Builder.Dependencies, "builder dependency")
+	CheckLatestVersion(aci.manifest.Tester.Builder.Dependencies, "tester builder dependency")
+	CheckLatestVersion(aci.manifest.Tester.Aci.Dependencies, "tester dependency")
+}
+
+func CheckLatestVersion(deps []common.ACFullname, warnText string) {
+	for _, dep := range deps {
 		if dep.Version() == "" {
 			continue
 		}
 		version, _ := dep.LatestVersion()
 		if version != "" && common.Version(dep.Version()).LessThan(common.Version(version)) {
 			logs.WithField("newer", dep.Name()+":"+version).
 				WithField("current", dep.String()).
-				Warn("Newer 'dependency' version")
+				Warn("Newer " + warnText + " version")
 		}
 	}
 }