fix: return ENOTSUP instead of -1 for unsupported syscalls #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative errno value is not expected at least by wasi-libc and
strerror(-1)
returns "Success" as an undefined behavior. To avoid such confusion, it might be better to returnENOTSUP
for unimplemented syscalls instead of invalid errno -1.This change makes
browser_wasi_shim
work with ruby.wasm.