Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.181212-rc1] Integration testing by toi16 - Settlement UI Issues #2284

Closed
toi16 opened this issue Dec 7, 2018 · 2 comments
Closed

[2.0.181212-rc1] Integration testing by toi16 - Settlement UI Issues #2284

toi16 opened this issue Dec 7, 2018 · 2 comments
Labels
[0] Duplicate Notification that this Issue is duplicated elsewhere. Reference should be added to Description

Comments

@toi16
Copy link

toi16 commented Dec 7, 2018

Describe the bug
A. When using the 'Settle Instantly' feature in the exchange the 'Request settlement of USD' modal allows you to try and settle more bitUSD than you actually have in your balance. You are able to confirm the transaction , but then get a 'Failed to broadcast the transaction' error.

B. When using the Margin Positions table to adjust a margin on bitUSD (ADDING A NEW MARGIN) you are able to create a new margin, and confirm your transaction, but then get a broadcast the transaction' error.

To Reproduce A

Steps to reproduce the behavior:

  1. Go to 'Exchange' bitUSD/BTS market
  2. Click on 'Settle Instantly'
  3. Enter 10 in 'Amount to Settle', (with a 0 USD balance)
  4. Click 'Settle Asset'
  5. Click 'Confirm,
  6. See error

To Reproduce B

  1. Go to 'Dashboard
  2. Click 'Margin Positions' Tab
  3. Click 'Adjust' icon next to 'bitUSD'
  4. Fill in the NEW margin debt and collateral.
  5. Click 'Update Position'
  6. Click Confirm
  7. See Error

Expected behavior A
After clicking on 'Settle Instantly' button in exchange the 'Request settlement of USD' modal should have the 'Settle Asset' button disabled leaving just the close button active, with a message stating that you have no USD in your balance to settle. OR The 'Settle Instantly' button is disabled on the exchange screen if you have no USD in your wallet to settle.

Expected behavior B
After clicking on the 'Adjust' button in the 'Margin Positions' table you should not be able to create a new margin, and should be notified that bitUSD is in GS. If you already have a margin the addition of a 'Settle Instantly' button should be displayed.

Screenshots
settle

settle2

settle3

settle4

My OS:
Windows 10, Version: 1803 (OS Build 17134.407)

My Browser:
Chrome, Version 71.0.3578.80 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

@startailcoon startailcoon added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [5b] Small Indicates size of task. Est. between one and two hours [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [2] Good First Issue Issue is a good issue to start with [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Dec 7, 2018
@startailcoon
Copy link
Contributor

These are two issues in one really. Well described by OP.

  • Once bit asset is in GS, change margin position should be disabled. Settle should be instant settle.
  • You shouldn't be able to use instant settle if you have a zero balance.

@startailcoon startailcoon changed the title [2.0.181212-rc1] Integration testing by toi16 - Settlement UI Issues [2.0.181212-rc1][1] Integration testing by toi16 - Settlement UI Issues Dec 7, 2018
@startailcoon startailcoon added this to the 181212 milestone Dec 7, 2018
@startailcoon
Copy link
Contributor

This is fixed, part of PR #2342 and others.

@startailcoon startailcoon changed the title [2.0.181212-rc1][1] Integration testing by toi16 - Settlement UI Issues [2.0.181212-rc1] Integration testing by toi16 - Settlement UI Issues Dec 15, 2018
@startailcoon startailcoon added [0] Duplicate Notification that this Issue is duplicated elsewhere. Reference should be added to Description and removed [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Good First Issue Issue is a good issue to start with [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4b] Normal Priority Priority indicating the moderate impact to system/user -OR- existing workaround is costly to perform [5b] Small Indicates size of task. Est. between one and two hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Dec 15, 2018
@startailcoon startailcoon removed this from the 181212 milestone Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[0] Duplicate Notification that this Issue is duplicated elsewhere. Reference should be added to Description
Projects
None yet
Development

No branches or pull requests

2 participants