Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action is broken on self hosted runners #2

Closed
margeauxg-medium opened this issue Sep 12, 2024 · 3 comments · Fixed by #3
Closed

This action is broken on self hosted runners #2

margeauxg-medium opened this issue Sep 12, 2024 · 3 comments · Fixed by #3

Comments

@margeauxg-medium
Copy link

Due to the use of ${{ github.action_path }}. See actions/runner#716

@bigwheel
Copy link
Owner

bigwheel commented Sep 13, 2024

@margeauxg-medium
Sorry I don't use this action by myself in few months.
I guess this will be resolved by actions/runner#716 (comment) , right ?

seems like env variable GITHUB_ACTION_PATH set to correct path. so step could be called via GITHUB_ACTION_PATH instead of ${{ github.action_path }}

  - run: ${GITHUB_ACTION_PATH}/setup.sh
    shell: sh

@margeauxg-medium
Copy link
Author

hi @bigwheel

No problem, just sharing what I discovered in my testing. I've tested with ${GITHUB_ACTION_PATH} locally and it does work on my self hosted runners. However I'm not sure of the implications of that on Github hosted runners.

@bigwheel
Copy link
Owner

@margeauxg-medium
I think this problem will be fixed in https://github.com/bigwheel/get-terraform-version-action/releases/tag/v1.3.0 .
I would apprecate if you agree to fix with your environment test (because I don't have Self Hosted Runner environment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants