Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*_channels.tsv: "units" column should be "unit" #729

Closed
hoechenberger opened this issue Feb 10, 2021 · 2 comments
Closed

*_channels.tsv: "units" column should be "unit" #729

hoechenberger opened this issue Feb 10, 2021 · 2 comments
Labels
EEG Electroencephalography iEEG MEG Magnetoencephalography

Comments

@hoechenberger
Copy link
Collaborator

In *_channels.tsv for MEG, EEG, and iEEG data, all column names except for software_filters and units are in the singular form. software_filters being plural does make sense because one may specify multiple filters per channel.

For units, however, I think the current specification introduces an inconsistency: to my knowledge, only a single measurement unit can be reasonably assigned to any given channel.

I would therefore propose to deprecate the units column in favor of a unit column.

Screenshot of the MEG specs:
Screen Shot 2021-02-10 at 16 56 13

@hoechenberger hoechenberger added MEG Magnetoencephalography iEEG EEG Electroencephalography labels Feb 10, 2021
@sappelhoff
Copy link
Member

I brought up some time in 2018 or 2019, but it was always deemed low impact and annoying, so we skipped it. Tracked here: bids-standard/bids-2-devel#15

@hoechenberger
Copy link
Collaborator Author

Whoops, I must've missed this when searching existing issues. Closing as a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EEG Electroencephalography iEEG MEG Magnetoencephalography
Projects
None yet
Development

No branches or pull requests

2 participants