Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema): Validate the iEEG data files have associated electrodes.tsv #1896

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(schema): Validate the iEEG data files have associated electrodes.tsv #1896

wants to merge 2 commits into from

Conversation

effigies
Copy link
Collaborator

Closes #1854.

@effigies effigies added this to the 1.10.0 milestone Aug 20, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (9377b20) to head (377c777).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1896   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files          16       16           
  Lines        1396     1396           
=======================================
  Hits         1230     1230           
  Misses        166      166

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Aug 20, 2024
Open
Open
@effigies effigies marked this pull request as draft August 21, 2024 18:32
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 21, 2024
@effigies effigies modified the milestones: 1.10.0, 1.10.1 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsalo tsalo Awaiting requested review from tsalo

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Milestone
1.10.1
Development

Successfully merging this pull request may close these issues.

[SCHEMA] Make electrodes.tsv REQUIRED for iEEG
1 participant
@effigies