Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include segments broken - Send custom notification #168

Open
Sml995 opened this issue Apr 25, 2022 · 2 comments · May be fixed by #169
Open

Include segments broken - Send custom notification #168

Sml995 opened this issue Apr 25, 2022 · 2 comments · May be fixed by #169

Comments

@Sml995
Copy link
Contributor

Sml995 commented Apr 25, 2022

In the last release an additional check is performed before setting $parameters['included_segments'] = ['All'] by default in sendNotificationCustom()

However the check is on the string instead of the array index:

empty('include_external_user_ids')

Should be:

empty($parameters['include_external_user_ids'])
@Sml995 Sml995 linked a pull request Apr 25, 2022 that will close this issue
Open
@sevak88
Copy link

sevak88 commented May 25, 2022

Any news??((

@Sml995
Copy link
Contributor Author

Sml995 commented May 26, 2022

@berkayk
Would be great to merge that, let us know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix array index access Sml995/laravel-onesignal
2 participants
@Sml995 @sevak88