Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the configuration of bentoml API server #1489

Closed
bojiang opened this issue Mar 8, 2021 · 2 comments
Closed

Restructure the configuration of bentoml API server #1489

bojiang opened this issue Mar 8, 2021 · 2 comments
Assignees

Comments

@bojiang
Copy link
Member

bojiang commented Mar 8, 2021

Is your feature request related to a problem? Please describe.
ref: #1476 (comment)

The current configuration structure for the API server:

api_server:
  port: 5000
  enable_microbatch: False
  run_with_ngrok: False
  enable_swagger: True
  enable_metrics: True
  enable_feedback: True
  max_request_size: 20971520
  workers: 1
  timeout: 60

marshal_server:
  port: Null  # default: api_server.port when enable_marshal=True

The batching server is seen as a standalone part, independent from the API server.
We can also see the batching layer as a consistent part of the bentoml API server.

So that bentoml could

  • enable the marshal(batching) server by default, making the metrics endpoint non-blocking.
  • pass requests by UNIX domain socket to achieve better performance.

Describe the solution you'd like

from @ssheng

api_server:
  marshal(or batching_layer):
    enable: true
    connector:
      type: TCP/UDS
      host: 127.0.0.1 # TCP only
      port: Null # TCP only. Default: auto-detect
      path: /path/to/the/uds # UDS only.
  port: 5000
  run_with_ngrok: False
  enable_swagger: True
  enable_metrics: True
  enable_feedback: True
  max_request_size: 20971520
  workers: 1
  timeout: 60

This structure reflects the idea above.

Describe alternatives you've considered

Additional context

@bojiang bojiang changed the title Restructure the configuration of API server Restructure the configuration of bentoml API server Mar 8, 2021
@ssheng ssheng self-assigned this Mar 10, 2021
@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2021
@parano
Copy link
Member

parano commented Jun 14, 2021

This is done in 6d64f33

@parano parano closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants